plotly.py icon indicating copy to clipboard operation
plotly.py copied to clipboard

Fix setup.py import of versioneer w/ PEP 517

Open thesamesam opened this issue 3 years ago • 4 comments

Same issue as https://github.com/dandi/dandi-cli/pull/998.

If versioneer is installed on the system, by appending our copy to the import path, we're going to end up colliding and mixing-and-matching.

We always want to use the local copy vendored in tree.

Bug: https://bugs.gentoo.org/841002 Signed-off-by: Sam James [email protected]

Code PR

  • [X] I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • [ ] I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

thesamesam avatar Jun 03 '22 06:06 thesamesam

The CI failure is unrelated.

thesamesam avatar Jun 04 '22 08:06 thesamesam

Hi there!

Sorry this is so late, I'm sweeping through long-opened PRs... Can you please expand a little bit on how this change solves the problem you're seeing? I'm not sure I understand...

Thanks! Nicolas

nicolaskruchten avatar Jan 04 '23 22:01 nicolaskruchten