plotly.R icon indicating copy to clipboard operation
plotly.R copied to clipboard

Compatibility with incoming ggplot2 changes

Open teunbrand opened this issue 1 year ago • 0 comments

Hi Carson and other maintainers,

Apologies for the cold PR! While building a new feature in ggplot2 we found through reverse dependency checks that {plotly} was negatively affected by the changes we'd like to implement. The new feature makes extensive use of computed values in the Geom$default_aes field, contrasted by mostly fixed values in the current CRAN version. Mostly, this PR resolves the relevant defaults before using them in {plotly}. The changes herein should be backwards compatible (locally tested with ggplot2 3.5.1).

In addition, a small change with regards to label setup is sneaked in for good measure. If you rather have a separate PR for that I'll prepare one.

We don't intend to release a new version of ggplot2 this year, so there isn't much of a hurry to merge this.

teunbrand avatar Jul 19 '24 20:07 teunbrand