plotly.R icon indicating copy to clipboard operation
plotly.R copied to clipboard

Isolate `names(...)` in `event_data()` to prevent spurious updates

Open dvg-p4 opened this issue 1 year ago • 1 comments

Closes #2337 by wrapping names(session$userData$plotlyInputStore) with shiny::isolate().

I don't think there's any good way to write an automated test for this, but you can verify that the reprex I gave in the issue no longer produces the spurious updates, while the click data continues to be correctly displayed.

dvg-p4 avatar Feb 05 '24 18:02 dvg-p4

@cpsievert is there anything else you'd like to see in the PR before approving the workflow / reviewing it?

dvg-p4 avatar Feb 13 '24 17:02 dvg-p4

Thanks! Will you also add a NEWS.md item?

cpsievert avatar Apr 26 '24 19:04 cpsievert

@cpsievert done!

dvg-p4 avatar Apr 26 '24 23:04 dvg-p4