Add support for ggalt::geom_dumbbell.
This PR adds support for ggalt::geom_dumbbell and closes #1454 .
-
The implementation follows
ggalt::GeomDumbbell. -
Tooltips only show up if hovering over the points and differ for the left and right point. To this end I added a util function
make_hovertextwhich overwrites the hovertext set bylayers2traces. -
I also added some tests and tried to add a visual test (which however failed when running the test while vdiffr::manage_cases showed me a successful doppelganger). Therefore the visual test is commented out in the test.
Hi Carson. First. Sorry for messing up the commit history.
- I folllowed your suggestions for simplifying the code, removing the duplicated code and renaming the variables.
- After commiting I realized that I thereby introduced a bug. The latest commits fix this bug. I also added an addtional test to check that.
- Finally I removed some code duplication by adding a function
segement2path.
Best, Stefan
I just added the visual tests to the PR. However, running the visual tests against the docker image failed with the message "there is no package called 'ggalt'". If I should guess ... this probably happens because ggalt is not included in the docker image.
Ah, yea, let's add ggalt to Suggests in the DESCRIPTION file