falcon icon indicating copy to clipboard operation
falcon copied to clipboard

Issue 362 table tree tests

Open shannonlal opened this issue 7 years ago • 1 comments

Added some simple tests to the Table Tree using Jest. This is related to #362 about adding some basic unit testing for the react components for testing

@n-riesco If you have a few minutes would you mind doing a quick review of this PR

shannonlal avatar Mar 25 '18 17:03 shannonlal

@shannonlal This PR breaks TreeTable. I've pointed out in the comments the two places where I think the breakage happens.

As usual, thanks for doing this. Reviewing this component has made me realise that we call storeSchemaTree unnecessarily. Once you're done with this PR, we can think how to avoid these redundant calls to storeSchemaTree.

n-riesco avatar Mar 26 '18 17:03 n-riesco