dash-player icon indicating copy to clipboard operation
dash-player copied to clipboard

console error

Open eckdqja opened this issue 2 years ago • 3 comments

a b

No problem with playback, but console error exposed

mycode in layout: c

eckdqja avatar Jun 16 '23 03:06 eckdqja

Thanks @eckdqja - looks like this line:

https://github.com/plotly/dash-player/blob/79b595710d1531bb2afa5702e41373eeee70a933/src/lib/fragments/DashPlayer.react.js#L146

should say className={className} instead. It's not exactly documented as a prop either way, but the underlying component does show one example with className: https://github.com/CookPete/react-player#responsive-player

alexcjohnson avatar Jun 16 '23 04:06 alexcjohnson

I request a correction through an update. (Release) I hope the issue will be resolved.

eckdqja avatar Jan 10 '24 00:01 eckdqja