plop icon indicating copy to clipboard operation
plop copied to clipboard

fix(node-plop): Correct types

Open xeho91 opened this issue 2 years ago • 0 comments

Hi, I love using your package to improve my workflows. Thanks for it!

While coding something new, I found a few typing issues, so I thought of immediately fixing them.


According to the code from these lines:

  • https://github.com/plopjs/plop/blob/973c1ce566db6fc754af55672b47ae4ed80ae4d0/packages/node-plop/src/actions/append.js#L32
  • https://github.com/plopjs/plop/blob/973c1ce566db6fc754af55672b47ae4ed80ae4d0/packages/node-plop/src/actions/modify.js#L30

both action types - "append" and "modify" - accept pattern property in options (cfg) optionally.


Another one is the incorrectly inherited property path inside AddManyActionConfig from AddActionCOnfig. I've confirmed there, that it is actually not being used at all.

Source: https://github.com/plopjs/plop/blob/973c1ce566db6fc754af55672b47ae4ed80ae4d0/packages/node-plop/src/actions/addMany.js#L15

xeho91 avatar Feb 15 '23 06:02 xeho91