plop icon indicating copy to clipboard operation
plop copied to clipboard

WelcomeMessage not displaying

Open yannvr opened this issue 7 years ago • 3 comments

Using version 2.1.0 Given the plopfile:

module.exports = function(plop) {
  plop.setWelcomeMessage('this is welcome message')
}

The welcome message will not display. This happens to me as well when I have a generator. It's strange because the plop example seems to work but I've never managed to get it working on my own plopfiles :(

yannvr avatar Oct 10 '18 08:10 yannvr

If you have only 1 generator, the welcome message is skipped and you are sent right into the only generator available. Sounds like this might be what you're seeing?

amwmedia avatar Oct 12 '18 17:10 amwmedia

Wow that's far fetched :) Most users will start with a single generators. I wanted mine as a disclaimer for some edge cases that the generator won't handle so I vote for decoupling the API from the number of generators

On Fri, 12 Oct 2018, 18:18 Andrew Worcester, [email protected] wrote:

If you have only 1 generator, the welcome message is skipped and you are sent right into the only generator available. Sounds like this might be what you're seeing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amwmedia/plop/issues/140#issuecomment-429397849, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPhx94vqjnR9o0CVWDvGH6iZTmTv10vks5ukM7PgaJpZM4XU0zT .

yannvr avatar Oct 16 '18 18:10 yannvr

I agree. I think the welcome message should show if it's specified. This was more of a consequence than a conscious decision. It came out of a request to automatically launch the generator if there is only one available.

However, if someone added their own welcome message... it should be shown regardless of how many generators there are.

amwmedia avatar Oct 17 '18 13:10 amwmedia