training icon indicating copy to clipboard operation
training copied to clipboard

Update customizing VLT

Open danalvrz opened this issue 4 months ago • 3 comments

  • [x] I have granted permission to publish my contribution according to Granting permission to publish. Minor typographical corrections and other contributions that are not "material in nature" are exempt from this requirement.
  • [x] I followed the guidelines in Contributing to Plone Training.
  • [x] I verified there aren't any other open pull requests for the same change.
  • [x] I successfully built the documentation and ran quality checks on my changes locally according to Building and Checking the Quality of Documentation.
  • [x] If needed, I added new terms to the Glossary file glossary.md and referenced them in the documentation. Note that terms that are defined in external Sphinx documentation, including Plone 6 documentation, may be referenced with a {term} directive without adding the definition to the local glossary.md file.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #


📚 Documentation preview 📚: https://plone-training--978.org.readthedocs.build/

danalvrz avatar Oct 08 '25 00:10 danalvrz

@danalvrz I went through all the code of exercise. I found some issue in hero block

  1. Title align not working if there is no image in hero block edit mode
  2. Same for subtitle
  3. object_browser not working if we remove the selected image in hero block.
  4. Another currently there is no initial width but we should have for hero block. see the screenshot for reference
Scree

iRohitSingh avatar Oct 11 '25 14:10 iRohitSingh

@danalvrz I went through all the code of exercise. I found some issue in hero block

  1. Title align not working if there is no image in hero block edit mode
  2. Same for subtitle
  3. object_browser not working if we remove the selected image in hero block.
  4. Another currently there is no initial width but we should have for hero block. see the screenshot for reference
Scree

@danalvrz Fixed .

iRohitSingh avatar Oct 12 '25 19:10 iRohitSingh

Sorry, I won't have time to give this a thorough review before the training tomorrow

I would strongly suggest that you perform the following checks to make sure you don't have any glaring errors or warnings.

  • https://training.plone.org/contributing/setup-build.html#livehtml
  • https://training.plone.org/contributing/setup-build.html#id1
  • and optionally https://training.plone.org/contributing/setup-build.html#overriding-configuration-options if you find that some checks are too noisy

stevepiercy avatar Oct 13 '25 13:10 stevepiercy