plone.restapi icon indicating copy to clipboard operation
plone.restapi copied to clipboard

Adding the specification for the API of Workflow manager

Open iRohitSingh opened this issue 3 years ago • 4 comments

iRohitSingh avatar Jul 03 '22 08:07 iRohitSingh

@iRohitSingh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mister-roboto avatar Jul 03 '22 08:07 mister-roboto

Deploy Preview for plone-restapi ready!

Name Link
Latest commit 1489eb543fede69c232a90796d5d1f9134c7c1a9
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/62c1573344da040009f9b606
Deploy Preview https://deploy-preview-1454--plone-restapi.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 03 '22 08:07 netlify[bot]

@robgietema can you please review and give feedback about this.

iRohitSingh avatar Jul 03 '22 08:07 iRohitSingh

Just some remarks here:

  • plone.app.workflowmanager is an addon - it is neither a dependency of Products.CMFPlone (core) nor of the Plone package
  • I tend to suggest to not add this endpoint to plone.restapi, but keep it within plone.app.workflowmanager package.

jensens avatar Jul 04 '22 09:07 jensens