asynchronous-injection icon indicating copy to clipboard operation
asynchronous-injection copied to clipboard

Is dotnet-xunit needed?

Open moodmosaic opened this issue 7 years ago • 2 comments

Perhaps dotnet-xunit can be removed from BookingApi.UnitTests.csproj(?)

$ git diff
diff --git a/BookingApi.UnitTests/BookingApi.UnitTests.csproj b/BookingApi.UnitTests/BookingApi.UnitTests.csproj
index c6581aa..acd844c 100644
--- a/BookingApi.UnitTests/BookingApi.UnitTests.csproj
+++ b/BookingApi.UnitTests/BookingApi.UnitTests.csproj
@@ -17,7 +17,6 @@
     <PackageReference Include="Moq" Version="4.9.0" />
     <PackageReference Include="xunit" Version="2.3.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
-    <DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
   </ItemGroup>

   <ItemGroup>
$ git clean -xdf
Removing BookingApi.UnitTests/bin/
Removing BookingApi.UnitTests/obj/
Removing BookingApi/bin/
Removing BookingApi/obj/
$ ./build.sh
Build started, please wait...
Build completed.

Test run for <...>\Ploeh.Samples.BookingApi.UnitTests.dll(.NETCoreApp,Version=v2.0)
Microsoft (R) Test Execution Command Line Tool Version 16.0.0-preview-20181205-02
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

Total tests: 4. Passed: 4. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 2.5872 Seconds

This is on a fresh Windows 10 (build 1809) with Visual Studio 2019 Preview (16.0.0 Preview 2.2).

moodmosaic avatar Feb 11 '19 13:02 moodmosaic

I've no idea... 😐

ploeh avatar Feb 11 '19 14:02 ploeh

I've no idea either... I guess Visual Studio must have added it, then.

moodmosaic avatar Feb 11 '19 14:02 moodmosaic