plex-media-player icon indicating copy to clipboard operation
plex-media-player copied to clipboard

Upgrade Qt (5.12)

Open mseeley opened this issue 7 years ago • 3 comments

This is a general Qt tracking issue.

Blocking this on build team availability. We'll address in a future cycle: https://github.com/plexinc/plex-conan/issues/517.

Context:

  • Chromium should have our patches applied: https://github.com/plexinc/plex-desktop/issues/40
  • Mojave dark mode support added in 5.12
    • Implementation: https://bugreports.qt.io/browse/QTBUG-68891
    • Blog: https://blog.qt.io/blog/2018/11/08/qt-macos-10-14-mojave/
      • Notice: There's some minimum SDK version comments
  • Fixes Qt ignoring modifier key swapping on macOS: https://github.com/plexinc/plex-media-player/issues/799#issuecomment-438806504.
  • Fixes inability to build a functional application on Mojave: https://github.com/plexinc/plex-media-player/issues/779
  • Hopeful regression fix for https://github.com/plexinc/plex-media-player/issues/772
  • Various window handling shortcomings are anticipated to be addressed.

mseeley avatar Nov 27 '18 00:11 mseeley

Qt 5.12.1 is out! Compiling against it works. On my Linux setup, I occasionally have audio dropouts.

###EDIT (again) ~~And even now with Qt 5.11.3, I have audio drop-outs. I don´t think it`s due to Qt. The Linux setup I use is with mesa/llvm "beta" (19.1/9) - regarding this -> issues are obvious. Sorry that I´ve blamed Qt for this. I will reinstall my Linux machine with mesa and llvm stable and probably Qt 5.12.1.~~ "to be continued" ~~Nope. not working correctly~~

~~Qt 5.12.3 is out... And it seems to be stable, no audio glitches what so ever...~~ audio drop outs......

###EDIT (again.....) Qt 5.12.4 is out... again it is working and then all of a sudden audio issues They are indicated as "ALSA XRUN hit, attempting to recover" So something about the buffer is messed up

mitzsch avatar Feb 02 '19 10:02 mitzsch

Cannot launch on Sway (Wayland based) on version 2.31.0.dev-a95b6d76 of pmp.

Xwayland is enabled.

Jpfonseca avatar Apr 16 '19 15:04 Jpfonseca

On my Linux machine, plex-media-player was working great with qt5-13.2. My Distro now provides qt5.14.1 and there are several Issues playing Video files. The player shows only the first frame of the Video file and the control menue ghosts. If I change to fullscreen, the picture updates but gets stuck at the next Frame. Would be nice if you could fix those Issues

ombre8 avatar Feb 13 '20 10:02 ombre8