seedit icon indicating copy to clipboard operation
seedit copied to clipboard

implement subplebbit.features for media in subplebbit settings and publishing forms

Open plebe1us opened this issue 1 year ago • 3 comments

subplebbit edit pics-art.sol --features.requirePostLinkIsMedia true

plebe1us avatar Mar 12 '24 15:03 plebe1us

should be a new setting group in SubplebbitSettings, called Features

plebe1us avatar Mar 13 '24 09:03 plebe1us

this issue should only be for a media feature setting for now, I guess just features.requirePostLinkIsMedia and features.noVideos

Rinse, [Mar 13, 2024 at 10:18:12 AM]: features.noVideos is not implemented yet

Tom (plebeius.eth), [Mar 13, 2024 at 10:20:47 AM]: I'm also checking media types so the front end can throw the error for now, if the boolean is defined

should add this media format check in submit page and reply form, to prevent users posting videos in a r/pics sub (if features.noVideos is true)

plebe1us avatar Mar 13 '24 09:03 plebe1us

Esteban Abaroa, [Mar 13, 2024 at 2:48:49 PM]: you should not implement stuff in the frontend that isnt implemented in backend, people can bypass it I dont even know if noVideos will be the actual name we use, it's just an example noVideos isnt consistent with requirePostLinkIsMedia maybe it should be postLinkIsNotVideo not sure

to do later

plebe1us avatar Mar 13 '24 17:03 plebe1us