playframework icon indicating copy to clipboard operation
playframework copied to clipboard

Add option to disable JavaScript routers

Open PromanSEW opened this issue 2 years ago • 3 comments

Pull Request Checklist

  • [X] Have you read How to write the perfect pull request?
  • [X] Have you read through the contributor guidelines?
  • [X] Have you referenced any issues you're fixing using commit message keywords?
  • [X] Have you added copyright headers to new files?
  • [X] Have you checked that both Scala and Java APIs are updated?
  • [ ] Have you updated the documentation for both Scala and Java sections?
  • [x] Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #12262

Purpose

Add option to disable JavaScript routers

PromanSEW avatar Dec 13 '23 05:12 PromanSEW

Thanks, I will do some local testing when I find time. Actually you said you don't need that urgently because you can just disable all reverse routes generate now and that solves your problem, yes?

mkurz avatar Dec 13 '23 08:12 mkurz

@mkurz yes, I don't need this change for now, disabling all routes was in fact I am looking for

PromanSEW avatar Dec 13 '23 08:12 PromanSEW

@mkurz can you review please?

PromanSEW avatar Jan 16 '24 16:01 PromanSEW

@Mergifyio backport 2.9.x

mkurz avatar Feb 27 '24 08:02 mkurz

backport 2.9.x

✅ Backports have been created

mergify[bot] avatar Feb 27 '24 08:02 mergify[bot]