playframework
playframework copied to clipboard
Changed to accept a test address to bind
Pull Request Checklist
- [ x] Have you read How to write the perfect pull request?
- [ x] Have you read through the contributor guidelines?
- [x ] Have you signed the Lightbend CLA?
- [x ] Have you referenced any issues you're fixing using commit message keywords?
- [ x] Have you added copyright headers to new files?
- [x ] Have you checked that both Scala and Java APIs are updated?
- [x ] Have you updated the documentation for both Scala and Java sections?
- [x ] Have you added tests for any changed functionality?
Fixes
Fixes #10927
Purpose
Allow changing address to bind to
At least one commit author ([email protected]) is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user
Done
Should be targeted to main branch instead
Also I don't understand why GitHub did not add link issue to "Successfully merging this pull request may close these issues" block...
@morellik thank you very much, however I merged #11509 instead which also contained tests and docs updates.