play-ws icon indicating copy to clipboard operation
play-ws copied to clipboard

Add mock support

Open wsargent opened this issue 9 years ago • 7 comments

It'd be nice to have mock WS client support, such as:

https://github.com/leanovate/play-mockws

wsargent avatar Dec 22 '16 20:12 wsargent

Maybe you have some advice regarding this issue on that repo? https://github.com/leanovate/play-mockws/issues/20

If that work was done on that repo would you guys be able to make use of it as the 'official' play-ws mock or would you still probably implement your own one?

MarkRBM avatar Feb 07 '17 17:02 MarkRBM

Note that play-ws-standalone is a pure interface-only API, so whatever is under the hood in play-mockws should work fine. There's always going to be extra dependencies in any implementation.

wsargent avatar Feb 07 '17 18:02 wsargent

https://github.com/f100ded/play-fake-ws-standalone supports standalone play-ws

tartakynov avatar Sep 19 '17 01:09 tartakynov

@wsargent play-fake-ws-standalone works really well. Does it make sense to include it in play-ws distribution?

fehmicansaglam avatar Jun 06 '18 20:06 fehmicansaglam

@fehmicansaglam that is entirely up to @f100ded / @tartakynov

wsargent avatar Jun 06 '18 23:06 wsargent

@fehmicansaglam @wsargent I'd love to include it into play distribution, if Play's team agrees

tartakynov avatar Jun 07 '18 00:06 tartakynov

Okay! Brought it up for discussion at https://discuss.lightbend.com/t/adding-mock-to-play-ws-standalone/1227 -- the advantage is it would be visible in the documentation, downside is that it would have to be published on the same cycle as Play WS standalone itself (i.e. no step releases).

wsargent avatar Jun 07 '18 17:06 wsargent