play-iteratees icon indicating copy to clipboard operation
play-iteratees copied to clipboard
verified publisher icon playframework

Remove ExecutionContext prepare

Open pjfanning opened this issue 7 years ago • 5 comments

Pull Request Checklist

  • [x] Have you read through the contributor guidelines?
  • [x] Have you signed the Typesafe CLA?
  • [ ] Have you squashed your commits?
  • [ ] Have you added copyright headers to new files?
  • [ ] Have you checked that both Scala and Java APIs are updated?
  • [ ] Have you updated the documentation for both Scala and Java sections?
  • [ ] Have you added tests for any changed functionality?

Fixes

Fixes https://github.com/playframework/play-iteratees/issues/21

Purpose

What does this PR do?

Removes the use of ExecutionContext#prepare

Background Context

Why did you take this approach?

Trying to remove deprecated functions.

Pre-supposes https://github.com/playframework/play-iteratees/pull/23 will be merged. If that PR is a problem, I can rework this PR.

References

Are there any relevant issues / PRs / mailing lists discussions?

https://github.com/playframework/play-iteratees/issues/21

pjfanning avatar Jan 18 '19 17:01 pjfanning

hi @pjfanning I am waiting for this change to be merged. Could you please fix the conflict?

masahitojp avatar Mar 22 '19 09:03 masahitojp

@masahitojp is this change ok? Github now has a squash option for merges so I haven't tried to squash the commits myself.

pjfanning avatar Mar 22 '19 12:03 pjfanning

@pjfanning Thanks! I think it's ok!

masahitojp avatar Apr 05 '19 08:04 masahitojp

How about this? @marcospereira. I think we should follow Play 2.7 and make it usable with Scala 2.13.x

masahitojp avatar Apr 10 '19 02:04 masahitojp

+1

dataich avatar Jun 10 '19 06:06 dataich