Display segment filters to anyone that can see the dashboard being filtered by the segment

[apata]

Changes

• Segment filters are displayed to anyone that can see the dashboard filtered by the segment, including for a personal segment applied on a public dashboard

Tests

• [x] Automated tests have been added

Changelog

• [x] Entry has been added to changelog

Documentation

• [x] This change does not need a documentation update

Dark mode

• [x] The UI has been tested both in dark and light mode

[github-actions[bot]]

Preview environment👷🏼‍♀️🏗️
PR-5935

[apata]

To see what's changed, click on the segment pill on these dashboards https://pr-5935.review.plausible.io/example-5935.site?f=is,segment,61&l=segment-61,artur%27s%20segment https://pr-5935.review.plausible.io/example-5935.site?f=is,segment,62&l=segment-62,site%20segment vs https://staging.plausible.io/example-5935.site/filter/segment?f=is,segment,61&l=segment-61,artur%27s%20segment https://staging.plausible.io/example-5935.site?f=is,segment,62&l=segment-62,site%20segment

[aerosol]

So is that change about not displaying the red warning?

[apata]

So is that change about not displaying the red warning?

@aerosol Yep! Before this, personal and site segment details weren't displayed to specific site roles, even though those roles were allowed to see the data filtered by the segment. The opacity had some benefits, since filters themselves can contain private info, but this PR removes that opacity.