analytics icon indicating copy to clipboard operation
analytics copied to clipboard

removed static tracker files

Open RobertJoonas opened this issue 3 years ago • 1 comments

Co-authored-by: Vinicius Brasil [email protected]

This PR aims to remove the generated static priv/tracker/js/*.js files from Git.

Changes

...

Tests

  • [x] This PR does not require tests

Changelog

  • [x] This PR does not make a user-facing change

Documentation

  • [x] This change does not need a documentation update

Dark mode

  • [x] This PR does not change the UI

RobertJoonas avatar Aug 17 '22 13:08 RobertJoonas

BundleMon

Unchanged files (7)
Status Path Size Limits
:white_check_mark: static/css/app.css
515.19KB -
:white_check_mark: static/js/dashboard.js
295.97KB -
:white_check_mark: static/js/app.js
12.13KB -
:white_check_mark: static/js/embed.host.js
5.58KB -
:white_check_mark: static/js/embed.content.js
5.06KB -
:white_check_mark: tracker/js/plausible.js
748B -
:white_check_mark: static/js/applyTheme.js
314B -

No change in files bundle size

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

bundlemon[bot] avatar Aug 17 '22 13:08 bundlemon[bot]

Have you tested whether the final Docker image works correctly?

One way to verify would be:

  1. Deploy this PR to the staging.srv.plausible.io server
  2. Hit it with curl to make sure all the tracker files are still available

I'm asking because the build steps are different for local development vs prod Docker image. Need to make sure both work

ukutaht avatar Oct 07 '22 10:10 ukutaht

I know you didn't change how the Dockerfile is build but still worth testing I think

ukutaht avatar Oct 07 '22 10:10 ukutaht

Have you tested whether the final Docker image works correctly?

One way to verify would be:

1. Deploy this PR to the staging.srv.plausible.io server

2. Hit it with `curl` to make sure all the tracker files are still available

We tested it with @vinibrsl. Deployed to staging and the files were generated nicely. We're planning to deploy it tomorrow.

RobertJoonas avatar Oct 10 '22 14:10 RobertJoonas

Nice, let's do it!

ukutaht avatar Oct 11 '22 10:10 ukutaht