Platon Rov

Results 84 comments of Platon Rov

Yea, I see that Table has negative margins but I don't see where the specs for that. Asked designers about it, waiting for a response.

Designers answered that they don't know why SAPUI5 implementation has this negative margins because of which we get this visual representation. Accordingly to the specs there are no any negative...

> * There's no way to dismiss the dialog Fixed. > * On mobile the dialog should take the whole screen. > Here are the guidelines: https://experience.sap.com/internal/fiori-design-web/dialog/#size-s-smartphone > Also check...

> You should probably use the compact button and align it with the other dismiss buttons (that belong to the notifications) as this will be immediately reported as a bug...

> Should it look like this in mobile? Nothing about notification itself, it comes from the dialog.

> it doesn't matter :) We shouldn't merge something that is broken or doesn't look ok. If it's coming from the dialog, either open a new issue that should be...

* [x] Avatar Group, no paddings on dropdown's input https://github.com/SAP/fundamental-styles/pull/3543 * [x] Quick View, no paddings on inputs https://github.com/SAP/fundamental-styles/pull/3543

* [x] Multi Input, outline margins https://github.com/SAP/fundamental-styles/issues/3495#issuecomment-1149148496

* [x] Object Marker, wrong focus state. In wiki said to use Link's focus designs. https://github.com/SAP/fundamental-styles/pull/3587