plantbreeding
/traits call returns "attribute" which should be linked to germplasmAttributes
As said in the title, the "/traits" call returns an "attribute" string property (class) defined as A trait can be decomposed as "Trait" = "Entity" + "Attribute", the attribute is the observed feature (or characteristic) of the entity e.g., for "grain colour", attribute = "colour". This should be linked to Germplasm Attribute data type (class).
Proposed change: traits.attribute should be turned into traits.attributeName and the Germplasm Attribute name definition should be turned into "Trait name" = "Entity" + "Attribute" so they would match each-other.
I assumed that the "Entity" + "Attribute" attribute and the GermplasmAttribute attribute were named the same thing by coincidence, not an intentional link. Are they really connected or describing the same thing? is it common to have these data points linked in most breeding/gene bank databases?
This may also create a circular dependency. GermplasmAttribute contains a Trait, then with this change the Trait would contain a reference to GermplasmAttribute. This seems odd to me...
"Entity" + "Attribute" is Crop Ontology term and relates to Traits, so it is completely independent of GermplasmAttribute.
