planet-client-python icon indicating copy to clipboard operation
planet-client-python copied to clipboard

Combine callback functions check_item_type(s) and move to specs

Open kevinlacaille opened this issue 2 years ago • 1 comments

In planet.cli.data and planet.cli.subscriptions, we have identical pairs of callback functions: check_item_type and check_item_types, which were temporarily introduced in https://github.com/planetlabs/planet-client-python/pull/905. These two functions are incredibly similar and we could probably be do with just one of them.

  1. Let's explore the possibility of removing one of the two callback functions in order to reduce complexity.
  2. Let's move these callback function(s) to planet.specs and update the Data and Subscriptions CLIs, the callback function(s) tests.

kevinlacaille avatar Apr 06 '23 20:04 kevinlacaille

Consider using a click ParamType for reuse

ischneider avatar Sep 05 '24 18:09 ischneider