planet-client-python icon indicating copy to clipboard operation
planet-client-python copied to clipboard

Clean up tests for Order request

Open kevinlacaille opened this issue 3 years ago • 0 comments

Move mock response and mock post out of the body of functions: https://github.com/planetlabs/planet-client-python/pull/519#discussion_r877368868

Review benefit of testing the permutation of id strings in multiple tests: https://github.com/planetlabs/planet-client-python/pull/519#discussion_r877373405

Invoke planet-data-request and planet-data-create in different tests: https://github.com/planetlabs/planet-client-python/pull/519#discussion_r877379374 - save some order request, say something like {"name": "test_order", "products": [{"item_ids": ["20200922_183724_23_106a", "20200922_183722_17_106a"], "item_type": "PSScene4Band", "product_bundle": "analytic"}]} in a new file in a tmpdir - Invoke create command invoke(['create', 'tests/data/newfile.json')

Combining geom_geojson and write_to_tmp_json_file into a single pytest fixture: https://github.com/planetlabs/planet-client-python/pull/519#discussion_r877396327

kevinlacaille avatar Jun 07 '22 16:06 kevinlacaille