planet-client-python icon indicating copy to clipboard operation
planet-client-python copied to clipboard

Add tests of --pretty option for get, cancel, wait, create, request commands of Data CLI

Open sgillies opened this issue 3 years ago • 1 comments

Discovered in https://github.com/planetlabs/planet-client-python/projects/2#card-81309600.

sgillies avatar May 05 '22 16:05 sgillies

The underlying logic is tested in a unit test for echo_json (here). Therefore, the only piece that isn't being tested is whether the pretty option is indeed passed to echo_json. This can be a very simple and copy/paste type of test where echo_json is mocked and the test checks to see if it got called with the pretty option as expected.

I am absolutely pro doing this and also I wouldn't triage this as high priority given the simplicity of the logic it tests.

jreiberkyle avatar May 19 '22 17:05 jreiberkyle