planet-client-python icon indicating copy to clipboard operation
planet-client-python copied to clipboard

feat: add item coverage and asset management in DataClient

Open wiki0831 opened this issue 10 months ago • 2 comments

The changes focus on improving item assessment(item-get,item-coverage), asset management(asset-get, asset-list) and making the API more consistent.

  1. implementations:
  • item-get: new in Async client, Sync Client, CLI
  • item-coverage: new in Async client, Sync Client, CLI
  • asset-get: new(un-commented) in CLI
  • asset-list: new in CLI
  1. tests
  • added async, sync, and cli test for the new implementations
  1. doc updates:
  • docs/cli/cli-data.md
  • design-docs/CLI-DATA.md
    • align parameter order with ITEM_TYPE, ID convention (few examples are out-of-date and no longer work)

wiki0831 avatar Mar 27 '25 14:03 wiki0831

looks good so far!

one thing we've been trying to do w/ tests is combine the sync/async calls into a single case since the setup and assertions are the same, the only difference is in invocation... see tests/integration/test_features_api.py for an example of this (and no reason to clean up existing tests, more to stop proliferation of new cases)

ischneider avatar Mar 27 '25 16:03 ischneider

looks good so far!

one thing we've been trying to do w/ tests is combine the sync/async calls into a single case since the setup and assertions are the same, the only difference is in invocation... see tests/integration/test_features_api.py for an example of this (and no reason to clean up existing tests, more to stop proliferation of new cases)

thanks @ischneider yes I agree, writing double the test is kinda tedious.

I was just trying to follow the existing pattern.

This should go into a separate PR. here is an issue for this: https://github.com/planetlabs/planet-client-python/issues/1110

wiki0831 avatar Mar 27 '25 16:03 wiki0831