pkgx icon indicating copy to clipboard operation
pkgx copied to clipboard

move interpreter detection to package.yml

Open jhheider opened this issue 3 years ago • 4 comments

Goes with your app.exec.ts rewrite, @mxcl.

Requires https://github.com/teaxyz/pantry.core/pull/33

jhheider avatar Nov 14 '22 22:11 jhheider

  • Added an Interpreter interface
  • Changed the unshift function to take in a new argument of type Interpreter instead of two strings (project and args)
  • Created getInterpreter which returns undefined if no interpreter is found for that extension, or else it returns an object with project and args properties
  • In exec(), we call usePantry().getInterpreter() on the file's extension, then pass its return value into unshift() as long as it isn't undefined

what-the-diff[bot] avatar Nov 14 '22 22:11 what-the-diff[bot]

Can't pass checks (fails tea -x setup.py) until pantry is merged.

jhheider avatar Nov 14 '22 22:11 jhheider

wonderful.

mxcl avatar Nov 16 '22 21:11 mxcl

rewrite complete

mxcl avatar Nov 17 '22 15:11 mxcl

lets add a test.

edit: probs this will do https://github.com/teaxyz/cli/pull/200

mxcl avatar Nov 25 '22 16:11 mxcl