brewkit icon indicating copy to clipboard operation
brewkit copied to clipboard

.cmake files need more touchups

Open jhheider opened this issue 2 years ago • 0 comments

See facebook.com/folly:

tea $ rg double-conv ~/.tea/facebook.com/folly/v2023/lib/cmake/folly 
/root/.tea/facebook.com/folly/v2023/lib/cmake/folly/folly-targets.cmake
70:  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/../../../boost.org/v1.82.0/include;${_IMPORT_PREFIX}/../../../google.com/double-conversion/v3.3.0/include;${_IMPORT_PREFIX}/../../../gflags.github.io/v2.2.2/include;${_IMPORT_PREFIX}/../../../google.com/glog/v0.6.0/include;${_IMPORT_PREFIX}/../../../libevent.org/v2.1.12/include;${_IMPORT_PREFIX}/../../../zlib.net/v1.2.13/include;${_IMPORT_PREFIX}/../../../openssl.org/v1.1.1t/include;${_IMPORT_PREFIX}/../../../sourceware.org/bzip2/v1.0.8/include;${_IMPORT_PREFIX}/../../../lz4.org/v1.9.4/include;${_IMPORT_PREFIX}/../../../facebook.com/zstd/v1.5.5/include;${_IMPORT_PREFIX}/../../../google.github.io/snappy/v1.1.10/include;${_IMPORT_PREFIX}/include"
71:  INTERFACE_LINK_LIBRARIES "fmt::fmt;Threads::Threads;Boost::context;Boost::filesystem;Boost::program_options;Boost::regex;Boost::system;Boost::thread;${_IMPORT_PREFIX}/../../../google.com/double-conversion/v3.3.0/lib/libdouble-conversion.so;gflags_shared;${_IMPORT_PREFIX}/../../../google.com/glog/v0.6.0/lib/libglog.so;${_IMPORT_PREFIX}/../../../libevent.org/v2.1.12/lib/libevent.so;${_IMPORT_PREFIX}/../../../zlib.net/v1.2.13/lib/libz.so;${_IMPORT_PREFIX}/../../../openssl.org/v1.1.1t/lib/libssl.so;${_IMPORT_PREFIX}/../../../openssl.org/v1.1.1t/lib/libcrypto.so;${_IMPORT_PREFIX}/../../../sourceware.org/bzip2/v1.0.8/lib/libbz2.so;${_IMPORT_PREFIX}/../../../lz4.org/v1.9.4/lib/liblz4.so;${_IMPORT_PREFIX}/../../../facebook.com/zstd/v1.5.5/lib/libzstd.so;${_IMPORT_PREFIX}/../../../google.github.io/snappy/v1.1.10/lib/libsnappy.so;dl;atomic;stdc++fs"

Our fixup.ts should do the same thing fix-machos/fix-elf do in terms of locating our software and shortening it to use v{{version.major}} to prevent hard-locking version dependencies. So far, this has only bitten us in facebook code.

jhheider avatar May 22 '23 18:05 jhheider