pkgcheck icon indicating copy to clipboard operation
pkgcheck copied to clipboard
verified publisher icon pkgcore

UnusedInherits on multilib and EAPI 5

Open atupone opened this issue 4 years ago • 3 comments

EAPI 5 does not provide get_libdir and inherit multilib is needed.

atupone avatar Sep 18 '21 20:09 atupone

Please paste the full output along with package name.

mgorny avatar Sep 18 '21 20:09 mgorny

pkgcheck scan tclperl-3.2-r1.ebuild

dev-tcltk/tclperl UnusedInherits: version 3.2-r1: unused eclass: multilib DeprecatedEapi: version 3.2-r1: uses deprecated EAPI 5

Thank

atupone avatar Sep 18 '21 20:09 atupone

There are two ways to solve this:

  1. Make the conditionalized EAPI default to 0 when unset for the multilib eclass in https://github.com/gentoo/gentoo/blob/master/eclass/multilib.eclass#L57.

  2. Rewrite global eclass parsing to use tree-sitter instead of its simple sourcing mechanism in https://github.com/pkgcore/pkgcore/blob/master/src/pkgcore/ebuild/eclass.py#L352 so it can scan past conditionals looking for global funcs/vars in a more robust fashion.

I'd advise taking route 1 if you want a quick fix for this specific issue.

radhermit avatar Sep 18 '21 23:09 radhermit