Karma-Read-JSON icon indicating copy to clipboard operation
Karma-Read-JSON copied to clipboard
verified publisher icon pizzapanther

Changed '/base/' on url to make it more generic. Added closure to function

Open rom3r4 opened this issue 11 years ago • 5 comments

rom3r4 avatar Jan 12 '15 20:01 rom3r4

I would like to keep the URL /base/ as the default option since that is the default Karma URL of where content is served and maybe have an option to override that instead.

pizzapanther avatar Jan 12 '15 22:01 pizzapanther

See Karma /base Directory at http://karma-runner.github.io/0.8/plus/RequireJS.html

pizzapanther avatar Jan 12 '15 22:01 pizzapanther

Hi! I think that the PR of @julianromera is correct, because this not allow to have your custom folders organization.

If you want, you can to use the basePath of karma by default, but if you cannot change the base is a big problem for use it.

rafa-suagu avatar Sep 08 '16 11:09 rafa-suagu

If you need a PR I can perform.

rafa-suagu avatar Sep 08 '16 11:09 rafa-suagu

@rafa-aguilar sounds good send me a PR

pizzapanther avatar Sep 08 '16 13:09 pizzapanther