pixiebrix-extension

pixiebrix-extension copied to clipboard

More strict null checks 2

2

## What does this PR do? - Adds various low-hanging fruit to strict null checks ## Checklist - [x] Designate a primary reviewer @BLoe

grahamlangford

MV3 sidebar loads very slowly and shows black panel when toggling from toolbar

17

## Describe the bug - MV3 sidebar shows black instead of loading html when toggling from toolbar - Time varies: can sometimes show for 1+ seconds - I'm on an...

twschiller

## Describe the bug MV3 open sidebar message appears in frames ## To Reproduce Steps to reproduce the behavior: 1. https://pbx.vercel.app/advanced-fields/ 2. Open Page Editor 3. Add a Sidebar Panel...

twschiller

Add Playwright helper for toggling the sidebar

1

Context --- - https://github.com/pixiebrix/pixiebrix-extension/pull/8160#discussion_r1552603481 - Current workaround is to add a click trigger to the page when testing a mod

twschiller

Playwright test for the Snippet Shortcut Menu

1

Acceptance Criteria --- - [ ] Simple test leveraging the Snippet Shortcut Menu Notes --- - Let's timebox initially to 1 day, then revisit - depending on LoE, we may...

grahamlangford

Definition of Done --- - [ ] Verify that AA OAuth2 integration is working in the Page Editor - [ ] Can be used with the Run Bot/Run API Task...

BLoe

Standardize modal hide/show logic to support transition animations

2

Context - https://github.com/pixiebrix/pixiebrix-extension/issues/2246#issuecomment-1128240540 - Modifying these will require some verification - by moving the flag to the show property, the we might hit null pointer errors if the code was...

twschiller

The Page Editor does not always update when clicking the browser’s back button

5

## Repro 1. Visit website A with host permissions 2. Open page editor - ✅ See "No extension selected" screen 4. Visit website B (regardless of permissions) - ✅ Editor...

fregante

Content script not loading in Salesforce CKEditor 4

18

## Describe the bug Selection popover not displayed in Salesforce CKEditor ## To Reproduce Steps to reproduce the behavior: 1. Define a context menu 2. Try to select some text...

twschiller

Update partner refresh token logic to fetch new access token when expired

5

Context --- * Follow-on to https://github.com/pixiebrix/pixiebrix-extension/issues/6603 * API calls should automatically fetch a new access token using the refresh token if the access token is expired * Similar to how...

grahamlangford