pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard
verified publisher icon pixiebrix

#9355: [WIP] fix dirty flag on Formik reinitialization regression

Open twschiller opened this issue 1 year ago • 3 comments

What does this PR do?

  • Fixes #9355
  • Regression from https://github.com/pixiebrix/pixiebrix-extension/pull/9351

Discussion

  • Our redux-logger middleware has an option for seeing the diff on each action: https://www.npmjs.com/package/redux-logger#options

Remaining Work

  • [ ] Fix playwright test: for discussion - when a brick configuration useEffect updates the Formik values automatically on mount, do we want that to show as unsaved changes?
    • Long-term the autom-running normalizations should to be moved into the form state adapter
  • [x] Add playwright test

For more information on our expectations for the PR process, see the code review principles doc

twschiller avatar Oct 26 '24 18:10 twschiller