pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard

#8596: improving mod definition snapshot capabilities - diffing

Open fungairino opened this issue 1 year ago • 2 comments

What does this PR do?

  • Part of #8596

Adds capabilities for comparing snapshots of mod definitions within end-to-end tests, improving the readability and focus of what is being tested. The new functionality will track the mod definition each time the snapshot is checked, and can be used even if the mod was not created via the modDefinitionNames fixture.

While writing this PR I also cleaned up some flaky behavior in editWorkshopModPage.ts which required some changes in the lifecycle spec.

Checklist

Leave all that are relevant and check off as completed

  • [ ] This PR requires a security review
  • [X] This PR introduces a new library: double check it's MIT/Apache2/permissively licensed
    • deep-diff - MIT
  • [X] Added jest or playwright tests and/or storybook stories

For more information on our expectations for the PR process, see the code review principles doc

fungairino avatar Jul 06 '24 01:07 fungairino

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.24%. Comparing base (8318d74) to head (404be8d). Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8754      +/-   ##
==========================================
- Coverage   74.24%   74.24%   -0.01%     
==========================================
  Files        1332     1332              
  Lines       40817    40826       +9     
  Branches     7634     7635       +1     
==========================================
+ Hits        30306    30312       +6     
- Misses      10511    10514       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 06 '24 01:07 codecov[bot]

Playwright test results

passed  83 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  86 tests across 30 suites
duration  13 minutes, 30 seconds
commit  404be8d

Flaky tests

edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

github-actions[bot] avatar Jul 06 '24 01:07 github-actions[bot]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

github-actions[bot] avatar Jul 08 '24 14:07 github-actions[bot]