pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard

Show mod under "Shared With Me" for team if mod is shared with that team

Open twschiller opened this issue 1 year ago • 2 comments

Describe the bug

  • "Shared with Me" section on mods screen doesn't show mod under all teams that the mod has been shared with
  • That's confusing in multi-team scenarios (e.g., prod vs. test team)
  • https://pixiebrix.slack.com/archives/C0436P48QHY/p1713915741908869?thread_ts=1713910443.800219&cid=C0436P48QHY
  • Triage: from an effort/impact tradeoff, this doesn't have a high "bang for buck" to fix

To Reproduce

Steps to reproduce the behavior:

  1. Create a mod in one team you're on (under that team scope)
  2. Share it with another team you're on
  3. On the mods screen, click on the second team

Actual behavior

  • Mod only shows on the original team under "Shared with Me"

Expected behavior

  • Mod shows under all teams it's shared with

Discussion

  • Will require adjusting 1) the shape of the ModViewItem to include all the teams the mod has been shared with, 2) adjusting the filtering on the mods screen

Related Code

  • https://github.com/pixiebrix/pixiebrix-extension/blob/0535e019ef2dad7a136d0600cd973fca9e4f57ee/src/mods/useModViewItems.tsx#L143-L143
  • https://github.com/pixiebrix/pixiebrix-extension/blob/0535e019ef2dad7a136d0600cd973fca9e4f57ee/src/extensionConsole/pages/mods/ModsPageSidebar.tsx#L294-L294

twschiller avatar Apr 25 '24 10:04 twschiller