pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard

#8015: Consolidate URL utils

Open fregante opened this issue 1 year ago • 1 comments

What does this PR do?

  • Complementary to https://github.com/pixiebrix/pixiebrix-extension/pull/8023

We have a couple of overlapping utilities and utilities appearing in unrelated files.

This also fixes a couple of bugs related to the baseURL removal

Checklist

  • [x] Add tests and/or storybook stories
  • [x] Designate a primary reviewer: @BLoe

fregante avatar Mar 31 '24 06:03 fregante

Codecov Report

Attention: Patch coverage is 95.45455% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.41%. Comparing base (1995795) to head (af6fa72). Report is 2 commits behind head on main.

:exclamation: Current head af6fa72 differs from pull request most recent head 9d9ebbf. Consider uploading reports for the commit 9d9ebbf to get more accurate results

Files Patch % Lines
src/integrations/UserDefinedIntegration.ts 75.00% 3 Missing :warning:
src/bricks/renderers/propertyTable.tsx 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8106      +/-   ##
==========================================
+ Coverage   73.37%   73.41%   +0.04%     
==========================================
  Files        1314     1312       -2     
  Lines       40722    40718       -4     
  Branches     7571     7561      -10     
==========================================
+ Hits        29879    29893      +14     
+ Misses      10843    10825      -18     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 31 '24 11:03 codecov[bot]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

github-actions[bot] avatar Apr 08 '24 17:04 github-actions[bot]