pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard

Extension Console integrations: Zapier modal cannot be closed

Open fregante opened this issue 1 year ago • 1 comments

Describe the bug

You can open it, but it stays open until a page reload

To Reproduce

Steps to reproduce the behavior:

  1. Go to chrome-extension://mpjjildhmpddojocokjkgmlkkkfjnepo/options.html#/services
  2. Click on "View key" next to Zapier
  3. Click "x" button

Actual behavior

Nothing happens, no errors in console. Even when clicking outside or pressing ESC.

Only the URL changes from #/services/zapier/ to #/services/

Screenshots/Loom

Screenshot 15

Desktop (please complete the following information):

  • Extension Version: 1.8.10-local

fregante avatar Feb 28 '24 17:02 fregante

Related URL bug

If you open chrome-extension://mpjjildhmpddojocokjkgmlkkkfjnepo/options.html#/services/zapier/ directly:

  • the modal doesn't open
  • the View Key button doesn't do anything

I vote to just drop this deep-link

fregante avatar Feb 28 '24 17:02 fregante

Upvoting this since I came across a user that hit it last week

brittanyjoiner15 avatar Apr 22 '24 15:04 brittanyjoiner15

@brittanyjoiner15 is this still happening for you? I'm not able to reproduce either problem locally or on the CWS version

Note that "esc" doesn't work, you have to click the "x"

I've created a PR with a Playwright test verifying the behavior: https://github.com/pixiebrix/pixiebrix-extension/pull/8633

twschiller avatar Jun 16 '24 15:06 twschiller

@twschiller interesting, not happening for me anymore either. must've gotten fixed with something at some point!

brittanyjoiner15 avatar Jun 17 '24 14:06 brittanyjoiner15

I don't remember the specific PR but I think I may have fixed this at some point... 🤔

BLoe avatar Jun 17 '24 14:06 BLoe