pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard

Slice 3: Move toolbar icon badges for background script errors under env flag

Open grahamlangford opened this issue 2 years ago • 4 comments

https://www.notion.so/pixiebrix/Phase-2-Add-Brick-for-Setting-Badge-in-Toolbar-04b12e551113443b9218317744dd864f?pvs=4#ec0aedbd082049a78079754432d3dcff

grahamlangford avatar Jan 09 '24 18:01 grahamlangford

I'd vote to use system notifications instead, it'd be quite useful.

The change would probably just be:

  • in manifest.mjs: add notification permissions if !isProduction
  • in errorsBadge.ts: use chrome.notifications.create() instead of browserAction.* calls (it'd make the file much simpler rather than longer)

fregante avatar Jan 11 '24 17:01 fregante

I'd vote to use system notifications instead, it'd be quite useful.

I'm OK with giving it a try. FWIW, I have Chrome system notifications off. Not sure if other developers do to. I prefer the badge based approach, but I'm not the one working with it as much

twschiller avatar Jan 11 '24 17:01 twschiller

Yeah I'm ok either way. I think I have notifications enabled but I only use chrome for development

fregante avatar Jan 11 '24 17:01 fregante

I'd vote to use system notifications instead, it'd be quite useful.

I like the idea; also on board with giving it a try

mnholtz avatar Jan 12 '24 19:01 mnholtz