pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard

Refactor/simplify `CreatableAutoSuggest` (too many `strictNullChecks` issues)

Open fregante opened this issue 2 years ago • 1 comments

Originally posted by @BLoe in https://github.com/pixiebrix/pixiebrix-extension/pull/6683#discussion_r1368895783

Furthermore, this CreatableAutoSuggest component appears to only be used in one place, in SelectorSelectorWidget. I'm not sure if this was used in more places previously, but if we only need to support the one widget, then this whole thing can/should be simplified a TON. Probably can remove a bunch of the props and make the rest required, based on the one widget call-site.

This is related to the strictNullChecks upgrade.

We have two options:

  • figure out how to handle the optional onCreateNew and renderCreateNew callbacks
  • simplify the whole component to avoid unnecessary complexity

fregante avatar Oct 23 '23 17:10 fregante

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

github-actions[bot] avatar Feb 13 '24 00:02 github-actions[bot]

completed

grahamlangford avatar Apr 24 '24 00:04 grahamlangford