Reconcile packageRegistry.ts:Kind with registry.ts:RegistryPackage.kind

[grahamlangford]

• The type of Kind in packageRegistry.ts should be a shorthand for RegistryPackage.kind in registry.ts
• The types do not perfectly overlap.
  • RegistryPackage.kind needs to be updated to include missing kinds
  • Only add kinds that are needed, there may be kinds in packageRegistry.ts:Kind that are unused.

[twschiller]

The context here is that:

• EditablePackageMetadata uses the display name: https://github.com/pixiebrix/pixiebrix-app/blob/be1c486eba393e3c8e2f99401f78af5958b4060b/api/models/registry.py#L210-L210
• RegistryPackage uses the value that appears in the YAML for user-defined packages: https://github.com/pixiebrix/pixiebrix-app/blob/43f0a4b81d8b7aaaf11adbe7fd8e4530ca4b8bf0/api/serializers/brick.py#L204-L204
• So previously we had shoved both of those into one type with lower casing
• What we need to do is look to see how packageRegistry is used and determine the actual values that flow through there to ensure the type is correct

[github-actions[bot]]

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

[grahamlangford]

This is part of the naming work that we still want to complete once we're further along with the service layer work.

[github-actions[bot]]

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.