pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard

Form UI/UX issues

Open fregante opened this issue 3 years ago • 7 comments

There are some small issues we could look into at some point

fregante avatar Jan 10 '23 09:01 fregante

The validation starts too early. In this case it should probably start when the form is submitted or at least after the user empties it.

no

Testable on https://app.pixiebrix.com/activate?id=@pixies/content-management-demo

fregante avatar Jan 10 '23 09:01 fregante

The PasswordWidget styling is a bit off, the border sometimes appears inside the field, sometimes it doesn't, and the eye icon is always outside it. We need to find a way to position the icon inside the field, where the "info" icon is.

no

Testable on https://app.pixiebrix.com/activate?id=@pixies/content-management-demo

fregante avatar Jan 10 '23 09:01 fregante

The error banner should not mention config. to the user:

Screenshot 5

Testable on https://app.pixiebrix.com/activate?id=@pixies/content-management-demo

fregante avatar Jan 10 '23 11:01 fregante

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

github-actions[bot] avatar Jan 22 '24 00:01 github-actions[bot]

Related:

  • https://github.com/pixiebrix/pixiebrix-extension/issues/5157

fregante avatar Jan 26 '24 17:01 fregante

The validation starts too early. In this case it should probably start when the form is submitted or at least after the user empties it.

The current logic is that the error will be show when the user has touched the field. We could potentially only show on dirty and if the form has been submitted. But we should look at this holistically across forms to not introduce consistent behavior. Not a priority at the moment

twschiller avatar Mar 24 '24 23:03 twschiller

The concept of user-invalid should be applied when it becomes higher priority: https://web.dev/articles/user-valid-and-user-invalid-pseudo-classes

fregante avatar Mar 25 '24 02:03 fregante