pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard
verified publisher icon pixiebrix

Drop `Router` if it's not used

Open BALEHOK opened this issue 3 years ago • 1 comments

BALEHOK avatar Aug 31 '22 13:08 BALEHOK

@BALEHOK IIRC, Router is required because RequireAuth now uses it. In RequireAuth I added some logic to always allow the /settings/ page of the extension to be accessible even if the user is not logged in. (Because there are some settings on there that impact what is considered logged in)

https://github.com/pixiebrix/pixiebrix-extension/blob/e09c6e28eeaab3f1e1403b1ceb5cefd491302d7b/src/auth/RequireAuth.tsx#L163-L163

twschiller avatar Aug 31 '22 13:08 twschiller

Is this about dropping an unnecessary dependency? Or just in this instance?

fregante avatar Aug 31 '22 19:08 fregante

Is this about dropping an unnecessary dependency? Or just in this instance?

@fregante eventually it is about removing Router from the app and dropping the dependency from Page Editor :)

BALEHOK avatar Sep 02 '22 11:09 BALEHOK