pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard

Update `webext-dynamic-content-scripts` to enable MV3 support

Open fregante opened this issue 3 years ago • 1 comments

What does this PR do?

  • Includes https://github.com/fregante/webext-dynamic-content-scripts/pull/38

The update preserves MV2 compatibility but should add support for MV3.

Since I'll be testing the extension on MV3, we need to start making sure that every component works as we switch between MV2 and MV3 during testing phase.

From preliminary testing, everything seems to work:

  • adding a new permission via page editor
  • opening the sidebar on a new website
  • opening the quickbar on a new website
  • detecting activeTab in the page editor
  • running bricks in a newly-created "target" tab from another tab

Future Work

  • [ ] #287

Merge notice

We should make sure that the logic was not broken so it's best to merge this at a convenient time, right after a release, so we can test it further during development (but I don't expect issues)

fregante avatar Aug 30 '22 12:08 fregante

Codecov Report

Merging #4185 (24ba60a) into main (a6aa32e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4185   +/-   ##
=======================================
  Coverage   48.57%   48.57%           
=======================================
  Files         877      877           
  Lines       26150    26150           
  Branches     5397     5397           
=======================================
  Hits        12703    12703           
  Misses      12519    12519           
  Partials      928      928           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 30 '22 12:08 codecov-commenter

69266298-santa-maria-nina-and-pinta-of-christopher-columbus

fregante avatar Sep 01 '22 05:09 fregante