pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard

Warn on non-pure bricks in renderer pipelines

Open twschiller opened this issue 3 years ago • 0 comments

Context

  • Users don't have control over when renderer pipelines run (e.g., the sidebar pipeline)

Implementation Sketch

  • Create an Analysis Visitor that checks the isPure property of a brick against the
  • Annotate with a warning if an impure brick appears in a renderer context
  • If the impure brick is the form-modal brick, recommend the Custom Form brick instead

Discussion

  • How accurate are our isPure annotations/logic? Do we need to carve out some exceptions? Change the warning level?

Related

  • https://github.com/pixiebrix/pixiebrix-extension/issues/4025

twschiller avatar Aug 15 '22 15:08 twschiller