pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard
verified publisher icon pixiebrix

Bump Font Awesome to 6

Open twschiller opened this issue 3 years ago • 5 comments

https://github.com/pixiebrix/pixiebrix-extension/pull/3825

  • [x] Release react-fontawesome 0.1.18 switch for Font Awesome 6: https://github.com/FortAwesome/react-fontawesome/releases
  • [ ] Need to re-enable dependabot
    • see https://github.com/pixiebrix/pixiebrix-extension/pull/7602#issuecomment-1937562013

twschiller avatar Jul 04 '22 18:07 twschiller

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

github-actions[bot] avatar Dec 28 '23 00:12 github-actions[bot]

This issue was closed because it has been stale for 7 days with no activity.

github-actions[bot] avatar Jan 04 '24 00:01 github-actions[bot]

I don’t think dependency updates are ever stale, we do want improvements and some icons are missing from v5

https://github.com/pixiebrix/pixiebrix-extension/pull/7567#discussion_r1482712263

fregante avatar Feb 08 '24 12:02 fregante

  • Blocked by https://github.com/webpack/webpack/issues/13865

fregante avatar Feb 09 '24 10:02 fregante

I think the solution to this would be to publish a "pre-rendered" @pixiebrix/icons package instead. I had suggest this also when dealing with the many drawbacks of icon loading a few years ago:

  • https://github.com/pixiebrix/pixiebrix-extension/issues/4187
  • https://github.com/pixiebrix/pixiebrix-extension/issues/2019

In short the @pixiebrix/icons package:

  1. reads the list of the icons
  2. exports it as a static array

I think that's just about it, maybe it could also include the CDN logic if that's what we want for Font Awesome too:

  • https://github.com/pixiebrix/pixiebrix-extension/pull/5865

It's best to keep the build as slim and generic as possible instead of adding more and more config to webpack. This will also likely speed up the build.

I recently had similar pains in Refined GitHub so I published a "pre-rendered" fork of GitHub's Octicons, which let me avoid SVGR. Script here https://github.com/fregante/octicons-plain-react/blob/2b669cbd97c35966b07d47028e2c7054a28ad78b/scripts/prepack.sh

fregante avatar Mar 14 '24 04:03 fregante

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

github-actions[bot] avatar Jun 13 '24 00:06 github-actions[bot]

This issue was closed because it has been stale for 7 days with no activity.

github-actions[bot] avatar Jun 21 '24 00:06 github-actions[bot]