pixiebrix-extension icon indicating copy to clipboard operation
pixiebrix-extension copied to clipboard

Clean up the old code for the save-extension UX

Open BLoe opened this issue 3 years ago • 2 comments

Related to #2557

There is now a lot of dead code in SaveExtensionWizard and useSavingWizard, since those will only ever be called for personal extensions, nothing with a recipe. We should delete the dead code, simplify these two as much as possible, and probably rename the hook to useExtensionSaver and can probably delete all of SaveExtensionWizard, and call SaveExtensionModal directly.

We should wait on this until after the new "create blueprint" feature is done, because this leftover code will be useful as a reference for that implementation.

BLoe avatar Apr 05 '22 17:04 BLoe

Blocked by #2932

BLoe avatar Apr 06 '22 23:04 BLoe

Split ElementWizard into EditorTabLayout and an implementation component, remove old code.

  • ElementWizard
  • AskQuestionModalButton

BLoe avatar May 12 '22 21:05 BLoe

This is definitely still worth looking into from a cleanup perspective, although some of the code in this area has changed/evolved since Apr2022

BLoe avatar Jun 27 '23 20:06 BLoe

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

github-actions[bot] avatar Jan 26 '24 00:01 github-actions[bot]

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

github-actions[bot] avatar Apr 26 '24 00:04 github-actions[bot]

This issue was closed because it has been stale for 7 days with no activity.

github-actions[bot] avatar May 03 '24 00:05 github-actions[bot]