pixie icon indicating copy to clipboard operation
pixie copied to clipboard

Support plugin service API calls from Go client

Open tharinduwijewardane opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. Cannot create/update retention scripts programmatically

Describe the solution you'd like Add the support to call plugin service API from Go SDK

Describe alternatives you've considered

Additional context

tharinduwijewardane avatar Aug 16 '22 03:08 tharinduwijewardane

This can be achieved by adding cloudpb.PluginServiceClient to the VizierClient struct

@aimichelle @zasgar Is this acceptable ?

tharinduwijewardane avatar Aug 16 '22 03:08 tharinduwijewardane

Hi @tharinduwijewardane ! Thanks for the suggestion! Registering plugin scripts is an operation done through the cloud, so it would actually make most sense to add it to the cloud client operations instead, and initialize the client here (see cmClient).

aimichelle avatar Aug 16 '22 21:08 aimichelle

I will send a PR soon

tharinduwijewardane avatar Aug 26 '22 04:08 tharinduwijewardane