pixie icon indicating copy to clipboard operation
pixie copied to clipboard

duplicate ConfigMap `pl-oauth-config` in `cloud_deps.yaml` file

Open gofrolist opened this issue 1 year ago • 0 comments

Describe the bug I'm trying to Install Air Gapped Proxy Cloud following official documentation https://docs.px.dev/installing-pixie/install-guides/airgap-pixie/#deploy-pixie-cloud and want to wrap it with kustomize but I noticed that there is duplicate ConfigMap pl-oauth-config in cloud_deps.yaml and cloud.yaml. I think it's not needed in cloud_deps.yaml because there is no usage of it in this file it used only in cloud.yaml.

To Reproduce Steps to reproduce the behavior:

  1. Download yaml files and extract it curl https://storage.googleapis.com/pixie-dev-public/cloud/latest/pixie_cloud.tar.gz | tar xj
  2. Create kustomization.yaml file
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- yamls/cloud_deps_elastic_operator.yaml
- yamls/cloud_deps.yaml
- yamls/cloud.yaml
  1. Run kubectl kustomize
  2. See error

Expected behavior see rendered yaml manifest output from kubectl kustomize

Logs

error: accumulating resources: accumulation err='merging resources from 'yamls/cloud.yaml': may not add resource with an already registered id: ConfigMap.v1.[noGrp]/pl-oauth-config.plc'

App information (please complete the following information):

  • Pixie version: 0.1.7
  • kubectl version: 1.29.1

Additional context I'm not sure how this bundle built but my thought is this part of code should be removed: https://github.com/pixie-io/pixie/blob/main/k8s/cloud_deps/public/configs.yaml#L21-L31 and keep only this https://github.com/pixie-io/pixie/blob/main/k8s/cloud/base/ory_auth/oauth_config.yaml

gofrolist avatar Feb 15 '24 20:02 gofrolist