NearPy icon indicating copy to clipboard operation
NearPy copied to clipboard

redis object not used in the _add_vector function

Open sarthakTUM opened this issue 5 years ago • 4 comments

Minor issue.

The redis_object in the _add_vector function of the storage_redis.py is not being used since the redis_object is already associated with self, and it should not be passed as an argument to the function.

sarthakTUM avatar Feb 16 '20 19:02 sarthakTUM

Thanks for notising this. redis_object should be used here instead of self.redis_object. This argument is necessary for store_many_vectors method.

amorgun avatar Feb 16 '20 21:02 amorgun

I'll revise the PR

sarthakTUM avatar Feb 17 '20 06:02 sarthakTUM

Thanks for notising this. redis_object should be used here instead of self.redis_object. This argument is necessary for store_many_vectors method.

Done

sarthakTUM avatar Feb 17 '20 20:02 sarthakTUM

@amorgun Could you please check the PR? - I am not able to add you as a reviewer there. Thanks!

sarthakTUM avatar Feb 18 '20 20:02 sarthakTUM