Andrew K
Andrew K
@eduard6 It's been 8 days and I still didn't get a reply. Are you still there? Sorry to bother with the messages, but I need to get my bills paid,...
I think it is ready for merging. Once you're ready @AdamISZ, you can send me the funds to 1K4z5ikWRBzj2UEyy4DiDYQ4yBdwA7yFBF. Thanks
Hi, I'm not sure how to fix the conflict with the TestWallet class in test/commontest.py. I added support for passing the password to the wallet constructor, but there seems to...
Hi thanks for coming through quickly on this. I will review it within the next few hours. I am also willing to do any tests you need, but then someone...
For the case of quitting before confirm, I thought this should handle this: https://github.com/JoinMarket-Org/joinmarket/pull/714/commits/fcc6b7b6b8e2ddd1d1f1c8b3e5a594328db91d58#diff-e5ebbf3237752f0c78e5834760582020R386 I put a call to new function "update_session_tx_pushed" right before the tx is broadcasted, and this...
I now increment the next_tx variable right after the confirm and before it is used in the tx loop. Also fixed some minor things you mentioned, and one subtle thing:...
For the wallet password, I can see some cases where it can be passed safely on the command line, such as in ram disk os or by disabling bash history....
ok I isolated the changes to the tumbler script and squashed the commits into 1, but did a force push (didn't know how to resolve it otherwise), so now I...
Forgot to test that last change. Will do now.
ok I think it is tested enough now so someone can merge or test further. Thanks.