client-php icon indicating copy to clipboard operation
client-php copied to clipboard

getDealParticipants not return correct data

Open zeman opened this issue 9 months ago • 9 comments

Version 9.0.0

getDealParticipants() rawData is not transformed into the correct PersonItem model.

Here's example data returned for a PersonItem.

Image

zeman avatar Apr 06 '25 22:04 zeman

This seems like it might be related. Getting a "Class "PersonItem" not found" when using addDealParticipant() to add a person to a deal. Request via API works fine and the deal is updated correctly but this error gets thrown.

Image

zeman avatar Apr 07 '25 02:04 zeman

@zeman hello!

I noticed that some data is missing in the response when using our SDK. Is this the same issue you're referring to?

dmitriyeff avatar Apr 08 '25 08:04 dmitriyeff

I've found a bunch of objects that are missing the data they should have. The data returned from the API is correct but the objects are not being created properly. You can use $response->getRawData(); to work directly with the API data rather than the incorrect models/objects created by the sdk.

zeman avatar Apr 10 '25 00:04 zeman

Is this the same issue you're referring to?

Yes, sounds like it. The raw data in the API response is correct but the SDK model is missing the properties it should have.

Here are the places I noticed missing data:

v2 getOrganization() is missing custom_fields v2 getDeals() is missing custom_fields v1 getDealParticipants() is missing person and emails (eg. first post in this thread)

zeman avatar Apr 10 '25 00:04 zeman

@dmitriyeff is this client library still supported by Pipedrive? Say it's the official PHP client but it seems neglected and I'm having to work around all sorts of missing data issues.

zeman avatar Apr 29 '25 21:04 zeman

Hey, @zeman, the PHP client is official and we are keeping track of the issues raised here. Also, updating the client. Apologies, if sometimes the issues are not tackled in a timely manner, but we'll definitely work on them.

siirimangus avatar May 05 '25 07:05 siirimangus

@siirimangus thanks. A month seems like a long time to not even acknowledge pretty major issues with the official client. Are they being worked on now? Or at least verified and confirmed as bugs?

zeman avatar May 05 '25 09:05 zeman

@zeman , yes, the issue has been verified and will be worked on.

siirimangus avatar May 12 '25 07:05 siirimangus

I assume it is still worked on?

Nightcro avatar Sep 24 '25 08:09 Nightcro