pipecd icon indicating copy to clipboard operation
pipecd copied to clipboard
verified publisher icon pipe-cd

Fix lint/go errors

Open kentakozuka opened this issue 2 years ago • 3 comments

What happened:

A Command make lint/go returns many errors.

What you expected to happen:

How to reproduce it:

Environment:

  • piped version:
  • control-plane version:
  • Others:

kentakozuka avatar Aug 25 '23 00:08 kentakozuka

I'd like to take up this issue :) I plan to resolve all lint errors and Integrate golangci-lint into GitHub Actions.

karamaru-alpha avatar Nov 07 '23 19:11 karamaru-alpha

Todo:

  • [ ] Confirm make lint/go return no error
  • [ ] Update CI to use make lint/go probably

khanhtc1202 avatar Mar 20 '24 23:03 khanhtc1202

I've just had a quick run locally, and there are quite a few issues still present (17 stylecheck, 4 unparam, 4 ineffassign, 8 gocritic) so I'll hop onto this one next, as I'd like to get a bit more familiar with the go code :) Just a quick check on this one actually, is pkg/app/pipedv1 still in use? Just because there also seems to be a pkg/app/piped? Cheers!

dgannon991 avatar Mar 29 '24 13:03 dgannon991